Luizmello/contacts app clean #2
Conversation
There was a problem hiding this comment.
Overall, I think you understood the general architecture we had discussed - good job! You set everything up using those principles. I left comments around just so you could see the overall thoughts but I didn't get super granular because I think we don't need to at this point. There's more to learn and understand but we have a good basis to go off of now.
| import SwiftUI | ||
|
|
||
| struct CircleImage: View { | ||
| var userImage: String |
There was a problem hiding this comment.
This should probably be named imageURL.
| Task(priority: .userInitiated) { | ||
| do { | ||
| let newPeople = try await self.fetchService.refreshPeople() | ||
| self.dataModel.people = newPeople |
There was a problem hiding this comment.
This could be combined with the line 38 like this:
self.dataModel.people = try await self.fetchService.refreshPeople()
| final class Coordinator: ObservableObject { | ||
| @Published var dataModel = DataModel() | ||
| @Published var fetchService = FetchService() | ||
| @Published var dataChanged: Bool = false |
There was a problem hiding this comment.
This variable either isn't needed or should be renamed to something more usable, such as isFetching because this would allow us to use this in other areas.
| } | ||
| } | ||
| func refreshPeople() async { | ||
| Task { |
There was a problem hiding this comment.
This probably shouldn't be in a Task because it reduces the flexibility of this call. Rather we would use Task at the call site.
| struct UsersListView: View { | ||
| @ObservedObject private var coordinator = Self.Coordinator() | ||
| var body: some View { | ||
| ZStack { |
| await self.coordinator.refreshPeople() | ||
| } | ||
| } | ||
| func move(from source: IndexSet, to destination: Int) { |
There was a problem hiding this comment.
| func move(from source: IndexSet, to destination: Int) { | |
| /// Move the person(s) from the given source index to the given destination location. | |
| func move(from source: IndexSet, to destination: Int) { |
| self.coordinator.dataChanged.toggle() | ||
| } | ||
|
|
||
| func removeRows(at offsets: IndexSet) { |
There was a problem hiding this comment.
This should probably be renamed to something more readable.
| func removeRows(at offsets: IndexSet) { | |
| func deletePersons(at offsets: IndexSet) { |
| Spacer() | ||
| } | ||
| } | ||
| struct contentBody: View { |
There was a problem hiding this comment.
No reason to do this. Because this isn't large, we can have this inside the detail view's body or as a computed property in the details view..
| var user: Person | ||
| var body: some View { | ||
| VStack(spacing: 5) { | ||
| Text("\(user.name.first ?? "Luiz") \(user.name.last ?? "Mello")") |
There was a problem hiding this comment.
We should probably use a computed property or lazy property on the Person object entitled displayName to make this more readable.
| func refreshPeople() async throws -> [Person] { | ||
| return try await self.refreshPeopleFromAPI() | ||
| } | ||
| func refreshPeopleFromAPI() async throws -> [Person] { |
There was a problem hiding this comment.
This should be private to keep the underlying code inaccessible.
| func refreshPeopleFromAPI() async throws -> [Person] { | |
| private func refreshPeopleFromAPI() async throws -> [Person] { |
Summary
I created an application that makes an API request (using async/await) presenting a list of users and a user details navigation.
I tried to apply the Coordinator pattern shown earlier and I believe I was able to do it successfully. Still, there were some changes to be made that I couldn't make.
Items Completed